pulen
November 14, 2022, 11:07am
1
Background
Background
I’ve been working as a Full Stack developer for 4 years now. I started working with .Net and Angular and then shifted to full javascript, working with Node, React, and React Native. On my free time I also started learning Next.js
I’ve been in the crypto environment since 2020, learning lots of stuff and all the time loving how much more there is to learn.
This will be my first time collaborating with a DAO and I’m very excited to do so! I’m convinced crypto and decentralization is t…
I’m a software engineer, I been working as a software developer for 4 years most of the time with technologies like .Net, Angular, SQL and also worked with React Native, Node, and a bit of Next.js
This is my second contributor proposal, I enjoyed the first one and I’m very excited and motivated to keep on contributing. You can read more about it here:
Retrospective
Woow these 3 months have been a loooot! New job, new type of organization, Devcon and DX retreat.
I enjoyed each one of these. I’m learning a lot and I have the feeling there is a lot more to learn. This is very motivating, but I have to admit it gets me a bit anxious so I’m trying to take it easy and learn one thing at a time.
I still have to familiarize myself with some concepts, which I’m confident that with time I will, and I’ll be able to get more involved in the meetings.
…
Goals
Work on supporting Gov 1.5 smart contracts in DAVI
Be involved in the planning and early technical stage of Gov 2.0
Support and fix bugs in DAVI
Keep improving and adding features to DAVI
Increase quality and test coverage on DAVI.
PR reviews
Be more involved in meetings
Improve my coding skills both in React as in Solidity
Improve my testing skills
Responsibilities
Work part-time per the bi-weekly planning session on smart contracts and front-end issues
Attend the daily calls, weekly relevant calls like development and governance, bi-weekly planning sessions, and other meetings.
Participate in the governance process
Compensation
Experience level: 2
Time commitment: 75% (30 hours per week)
Month 1 [8/11/2022 - 8/12/2022]
3.000 DAI (4.000 DAI * 75%).
1500 DXD (2.000 DXD * 75%), vested for 3 years with a 1-year cliff starting the 8/11/2022
0.125025% REP (0.1667% * 75%)
Month 2 [8/12/2022 - 8/1/2023]
3.000 DAI (4.000 DAI * 75%).
1.500 DXD (2.000 DXD * 75%), vested for 3 years with a 1-year cliff starting the 8/12/2022
0.125025% REP (0.1667% * 75%)
4 Likes
ross
November 14, 2022, 12:18pm
2
Tomás has been doing a fantastic job onboarding and it was a pleasure to meet him in Colombia.
Glad you are increasing your time commitment and can’t wait to see you learn and contribute more!
2 Likes
pulen
January 10, 2023, 11:04am
3
Retrospective
This proposal should end on 8/1/2023 but i’ll end it one week earlier and claim the rest of the proposal on a new one submitted on DAVI.
For Month 2, instead of what was submitted on this proposal i’ll claim:
2.225 DAI (23 days instead of 31 → 23*3.000/31)
1.113 DXD (=23*1.500/31) vested for 3 years with a 1-year cliff starting the 8/12/2022
0,093% REP (=23*0,125/31)
What went well
During this period we worked on implementing TheGraph, subgraphs for DAVI which we did doing pair programming with very good results. In a very short time we had a functioning version which will add a lot of value to DAVI when we get it integrated. I enjoyed working on it and learning new stuff.
Most of the other PRs were working on DAVI, both features and bugs. I’m feeling each time more comfortable working on DAVI’s code and I feel I’m adding value to it.
What to improve
Each issue I have on DAVI I try to do it consciously, trying to understand well how and why things are done as they are. This makes me a bit slower to do each task, but I see it as a good investment for next ones.
I feel I still have stuff to learn on smart contracts and specifically on the dao which will help me get more involved both on the programming as on the DAO in general.
Contributions
DAVI
DXgovernance:develop
← rulfo71:#338-fix-block-explorer-links
opened 02:41PM - 07 Nov 22 UTC
# Description
Fixing block explorer links through the app
Closes #338
…


## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manually for now
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:use-local-richContracts-on-development
opened 02:26PM - 15 Nov 22 UTC
# Description
On development use richcontracts from src/configs/ and on produ… ction uses "contracts.projectdavi.eth"
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
creating a proposal i checked that external contracts where the ones on src/configs
# Checklist:
- [X] My code follows the existing style of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:develop
opened 01:34PM - 21 Nov 22 UTC
# Description
upgrading version to 2.1.0
Closes # (issue)
## Type of c… hange
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:add-extra-validation-for-bytes32
opened 05:21PM - 21 Nov 22 UTC
# Description
Add extra validation for bytes 32 as talked with @rossneilson
…
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:fix-white-spaces-on-address-input
opened 02:07PM - 07 Dec 22 UTC
# Removing white spaces on address input
Also added a validation of null on u… seTimeDetail.ts
Closes #448
## Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
- Create a proposal
- Add action
- Transfer
- On Recipient try to add white spaces and it shouldn't allow you
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:fix-white-screen-on-url-with-no-network
opened 06:11PM - 08 Dec 22 UTC
# Added the case we dont have a last used chainId
Closes #447
## Type of … change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
open the app without specifying a chain
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:allow-setting-value-in-function-call-permissions-setting
opened 03:39PM - 09 Dec 22 UTC
# Description
Allow setting of value in function call permissions setting
… [Screencast from 09-12-22 12:01:47.webm](https://user-images.githubusercontent.com/5303411/206737804-c3f29888-3576-46a5-aebe-d958bcd20a89.webm)
Closes #442
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Create proposal, add action, set permissions, function call, change amount
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:hookStore-poc
opened 12:51PM - 13 Dec 22 UTC
# Description
POC to test a Context where we can get data from different sour… ces like subgraph and contract reads
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
DXgovernance:develop
← rulfo71:fix-action-options
opened 12:52PM - 15 Dec 22 UTC
Closes:
- DXgovernance/davi-monorepo#5
- DXgovernance/davi-monorepo#4
- DXg… overnance/davi-monorepo#3
# Description
- Removing call from editable action and checking null.
- Iterating on decodedActions instead of Actions for options
- Fix on getPermissionArgs for raw transactions
both bugs found with madusha and ross
Before:
[Screencast from 15-12-22 12:05:41.webm](https://user-images.githubusercontent.com/5303411/207896117-50db9eac-0937-496b-96f8-911d4bb14b21.webm)
After:
[Screencast from 15-12-22 12:06:54.webm](https://user-images.githubusercontent.com/5303411/207896140-c68a72be-3e34-491d-953b-3953d5bbe796.webm)
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
adding action vesting contracts
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
Subgraph
DXgovernance:master
← DXgovernance:merged-changes
opened 02:50PM - 28 Nov 22 UTC
DXgovernance:master
← DXgovernance:adding-members
opened 12:09PM - 06 Dec 22 UTC
- Added ERC20SnapshotRep
- Added TokensLocked
- Added GuildType (hardcoded for… now)
Smart contracts
DXgovernance:refactor-dxdao-contracts
← rulfo71:S1.incomplete-check-that-certain-functions-dont-transfer-value
opened 02:59PM - 07 Nov 22 UTC
S1. Incomplete check that certain functions don’t transfer value
On line 148, … there is a check that proposed calls which target ERC20-style transfer and approve
functions cannot send ETH value with the transaction.
This check is unnecessary, because these functions are not payable in ERC20 contracts and so will
revert. For contracts that do have payable functions, the check is also easy to bypass by calling
transferFrom instead of transfer, or (if implemented) by calling increaseAllowance and
decreaseAllowance instead of approve.
Recommendation: This check (and the entire loop, lines 144 to 153) is both unnecessary and incomplete,
and so we suggest removing it.
4 Likes