We are starting with Releases and doing planning for launch, discussing with Kenny and Ross to be more available for a few standups during the week. Thank you for improvements and great proposals. Work on automation is not fast enough ‘cause we have a lot of PR’s that need to be tested, I think that’s priority so far because of preparation for launch to PROD. First step for improvement is to have a Smoke test ready in the pipeline which will be triggered on every merge to develop branch. Work a lot on Regression testing on release branches and communicate using a clear issue list.
Successful constant testing and retesting of PRs. I tried to describe the bugs or strange behavior as well as possible so that the devs could understand and find solution to improve the state
Improving FTC (Test Scenarios, Test Cases and HappyPath) so that they can be ready for automation tests but also for onboarding new members who would pass the manual testing according to the instructions from these documents and get to know better all the possibilities and features of Guilds
Retrospective of the QA work done so far in order to look back on what has been done and consider how we can improve the work done so far and improve the work process even more
Start with automation and working still on LOCAL, plan to push when Smoke test will be ready for the first stage
Improved my understanding of Guilds and changed my approach in some specific cases. Need to work more on application knowledge and going deeply with it.
I understand the values of being a member of a DXdao and remaining self-motivated, disciplined, and consistent in my work. Working at DXdao makes contributors not only better in the technical field or DeFi experts, but also better people who work on themselves in every field and “fight” with themselves to achieve the same goal of decentralization.
I was focused on contributing to Guilds as soon as possible and “serving a purpose” as a QA Engineer as much as I can for this trial period I haven’t had that much time to learn and get to know more about DXdao in general and other projects mentioned in the weekly meetings, so my goal is to improve to benefit the community and beyond the Guilds project but to continue to contribute to Guilds as needed and more.
#233 - fix: Remove proposal types page and fix nft factory
DXgovernance:develop ← rossneilson:feature/remove-proposal-type
opened 03:05PM - 19 Aug 22 UTC
# Description
- Renamed create pages a little
- Removed proposal types from … links since they currently have no functionality
- Add check before adding nft factory to localhost
- Removed search and create button from landing page since they currently have no functionality
Closes #219
Closes #72
Closes #73
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#236 - Fix: Two digit bug input
DXgovernance:develop ← dcrescimbeni:fix/two-digit-bug-input
opened 06:40PM - 22 Aug 22 UTC
# Description
**Closes #83**
Previous behaviour: when the `TokenAmountInp… ut` field was empty and a user tried to input a number, after the first keystroke, the text was formatted to "X.0" and the caret jumped to the end of the string.
Now there's a 350ms delay between the last keystroke and the `value` assignment (and formatting).
https://www.loom.com/share/9ee19481f0934329a2d0a96c58f0137c
**Closes #204**
Clicking anywhere inside the `TokenAmountInput` component will either focus (click) or select its content (double click).
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#237 - Feature/folder cleanup
DXgovernance:develop ← MiltonTulli:feature/folder-cleanup
opened 06:44PM - 22 Aug 22 UTC
# Description
- Remove /old-components folder. All components have been moved… to /Components folder or removed if wasn't being used.
- Remove /abis folder. Moved all previous abis into /contracts folder with same structure `{ abi, contractName, ...}`
- Rename /Components folder to /components
- Rename /components/primitives to /components/primitives
- Refactor components to be named exports
- Fixes (mapping keys, semantic html, etc)
Closes https://github.com/DXgovernance/DAVI/issues/215
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#238 - fix: Get storybook working with Wagmi
DXgovernance:develop ← mprasanjith:bugfix/get-storybook-working-with-wagmi
opened 11:40AM - 23 Aug 22 UTC
# Description
After trying multiple options to get a mock provider working, r… esorted to just adding a generic provider.
Closes #217.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#239 - Fix: tooltip flickering
DXgovernance:develop ← dcrescimbeni:fix/tooltip-flickering
opened 06:54PM - 23 Aug 22 UTC
# Description
New `Tooltip` component that wraps over any element or text. Sh… ows tooltip text on hover and on click (for mobile interaction).
Can be positioned either `top` or `bottom`.
Fixes flickering on hover.
Closes #189
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#241 - Refactor/ether swr to wagmi [PART 1]
DXgovernance:develop ← Kenny-Gin1:refactor/ether-swr-to-wagmi
opened 08:41PM - 23 Aug 22 UTC
# Description
This is the first part of three to refactoring our hooks to use… wagmi completely. I added some tests to it as well.
- Refactoring and moving all the hooks to `hooks/Guilds/ens`
- Adding tests for all the hooks (except `useENSAvatar`)
TODO: Add tests to `useENSAvatar` after further refactoring.
Closes # https://github.com/DXgovernance/DAVI/issues/240
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manually and unit tests.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#242 - Fix staking modal title
DXgovernance:develop ← mprasanjith:bugfix/stake-swap-text-duplication
opened 03:01PM - 24 Aug 22 UTC
# Description
Fixes title in staking modal. Also cleans up the staking modal … components.
Closes #194.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#244 - Fix: currency filters crash the app and ENS content update action error
DXgovernance:develop ← dcrescimbeni:fix/currency-filters-chrash-the-app
opened 02:23PM - 25 Aug 22 UTC
# Description
**Closes #195**
Small bug fix.
**Closes #202**
Thi… s is not a bug, its a feature.
The current implementation only supports Mainnet and Goerli. There is a check to hide this action if the user isn't in a supported chain.
However, for development purposes (mainly to work on the UI), it also shows on localhost, but the proposal creation won't work.
I added a warning in the console to inform of this scenario.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#245 - Fix proposals filter
DXgovernance:develop ← MiltonTulli:fix/actions-filter
opened 07:29PM - 25 Aug 22 UTC
# Description
Fix ProposalCardWrapper filters and improve filter hook types. …
Closes https://github.com/DXgovernance/DAVI/issues/205
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#248 - feat: Show mint action properly
DXgovernance:develop ← rossneilson:feature/rep-mint-action
opened 11:06AM - 26 Aug 22 UTC
# Description
Adding a rep action in a rep guild will show up correctly and a… llow the user to edit beneficiary.
There are issues with bytecode in goerli but all guild type matching should work in localhost
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#249 - Refactor theme config and update theme tokens
DXgovernance:develop ← mprasanjith:feature/theme-config-refactor
opened 11:47AM - 26 Aug 22 UTC
# Description
Refactor color theme config of DAVI and updates usages across t… he app. The config has been simplified, with duplicate color tokens removed. Everything has been matched with the Figma.
Closes #214.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#250 - Fix: disconnect wallet
DXgovernance:develop ← dcrescimbeni:fix/disconnect-wallet
opened 01:36PM - 26 Aug 22 UTC
# Description
Fixed error while disconnecting wallet.
Added some translati… ons.
Closes #243
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#256 - Add SWPR token transfer permissions on localhost for swapr guild
DXgovernance:develop ← rossneilson:fix/removing-semi-colons
opened 10:07AM - 30 Aug 22 UTC
# Description
Small bug where we had colons appearing in between our loading … cards
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#262 - Refactor/ether swr erc20 nft
DXgovernance:develop ← Kenny-Gin1:refactor/ether-swr-erc20-nft
opened 11:55AM - 30 Aug 22 UTC
# Description
This is the second part of three to refactoring our hooks to us… e `wagmi` completely. I added some tests to it as well.
Refactoring and moving all the hooks to `hooks/Guilds/erc20` and `hooks/Guilds/nft`
Adding tests for all the hooks ERC20 and NFT.
Note that some of the tests just mock out the entire file. It is not optimal - but the purpose of these tests is rather to enhance the developer experience and quickly understand what should be returned from the hooks.
Closes # https://github.com/DXgovernance/DAVI/issues/261
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual and unit testing.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#265 - General updates and fixes for demo
DXgovernance:develop ← rossneilson:feature/token-list
opened 01:20PM - 31 Aug 22 UTC
# Description
-Adding project davi to header
- Adding extra toLowerCase func… tion to ensure matching tokens
- Added weth and correct swpr token to goerli token list
- Added new goerli subgraph for swapr (no pairs yet)
Additional changes
- Allowing zero value when setting function permissions
- New rich contracts with correct swapr fee setting address
- Fixed ens on all networks
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#266 - Refactor/ether swr guilds
DXgovernance:develop ← Kenny-Gin1:refactor/ether-swr-guilds
opened 07:06PM - 31 Aug 22 UTC
# Description
This is the third part of three to refactoring our hooks to use… `wagmi` completely. With this third refactoring, we have finally sunset `ether-swr`. This will hopefully come together as a better experience for the end-user since we are now optimizing how we fetch data from our contracts. E.g. polling.
I added some tests to it as well.
- Refactoring and moving all the `hooks/Guilds/guild` to `Module/Guilds/Hooks`.
- Adding tests for all the hooks.
Note that the tests just mock out the entire file. It is not optimal - but the purpose of these tests is rather to enhance the developer experience and quickly understand what should be returned from the hooks.
NOTE: This is a very big refactor and moving of files. I have tried to check for as many errors and/or bugs as possible manually that might have appeared with this refactor. But please be vigilant of any changes that you might see.
Questions to ponder in this PR:
- The test files basically mock out the entire corresponding hook file and the purpose is for them to understand the usage of the hooks and what it is meant to return. Is this useful or not? If not, I will remove all of them.
- There is one known error I am getting at the moment `Invalid BigNumber value argument="value", value=null, code=INVALID_ARGUMENT`. I cannot see that it breaks anything at the moment and am not sure if it was introduced in this branch or not.
Closes # ([issue](https://github.com/DXgovernance/DAVI/issues/278))
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Unit-testing and manual testing.
# Checklist:
- [ ] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#267 - Add summary for spending calls
DXgovernance:develop ← MiltonTulli:feat/interact-with-spending-calls
opened 08:55PM - 31 Aug 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes https://github.com/DXgovernance/DAVI/issues/196
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
## Images
#273 - Feat: Get all discussions on landing page
DXgovernance:develop ← dcrescimbeni:feat/get-all-discussions-on-landing-page
opened 03:54PM - 01 Sep 22 UTC
# Description
Discussions for each guild show on the main view (governance).
…
Features:
- Performant infinite scrolling (using react virtuoso)
- Refreshes all fetched discussions every 10 seconds (configurable)
- Component can be set anywhere to show the discussions relevant to that guild
Currently, clicking on the discussion card does nothing. This functionality will be implemented in the future.
Closes #176
Screen showing discussions
When there are no discussions in the guild:
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Snapshot tests.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#274 - fix: Support multiple versions of bytecodes and fix bytecode matching
DXgovernance:develop ← mprasanjith:bugfix/match-bytecodes-properly
opened 06:22PM - 01 Sep 22 UTC
# Description
We had issues with bytecode matching due to environments having… different bytecodes deployed. Also replaces Ethers with `crypto-js` for hashing bytecodes as Ethers was giving incorrect hashes for some reason.
Closes # (issue)
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally and on Goerli deployment.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#275 - Display consistent params for generic calls
DXgovernance:develop ← MiltonTulli:feat/generic-calls-params
opened 08:03PM - 01 Sep 22 UTC
# Description
Show the parameters in a simple way once initially expanding ge… neric call actions.
Closes https://github.com/DXgovernance/DAVI/issues/207
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
## Video
https://user-images.githubusercontent.com/25844967/189235418-7bd61481-8750-4526-a545-70eea998073a.mov
#282 - fix: Remove global error boundary
DXgovernance:develop ← DXgovernance:bugfix/deployment-crash
opened 06:25AM - 05 Sep 22 UTC
# Description
The global error boundary was a bit trigger happy and was getti… ng triggered unnecessarily. The Global error boundary was initially added to show a warning on DXvote when the cache loading fails and no longer is relevant. I think we should implement localized error boundaries at some point instead of having a global one.
On a separate issue, the app seems to try to connect to localhost RPCs somewhere in our code and fails with an unhandled exception, which I believe in turn triggered the error boundary. This should be investigated later and might even be solved after the recent refactors.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested on preview deployments.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#285 - Fix useProposalCalls
DXgovernance:develop ← MiltonTulli:fix/proposal-calls
opened 03:22PM - 05 Sep 22 UTC
Fix useProposalCalls to display correct calls in ActionsBuilder options
### I… ssue
Proposal calls are being shown under the wrong option.
### IMG of the issue
I added call details on the proposal description to be sure of how I submitted the proposal
### IMG after fix:
#286 - Feat: IPFS pinata pin
DXgovernance:develop ← dcrescimbeni:feat/ipfs-pinata-pin
opened 09:16PM - 05 Sep 22 UTC
# Description
Proposal data now gets pinned to Pinata service.
If for some… reason the content can't be pinned, it shows a modal, prompting to retry the upload, make the proposal without uploading the file, or close the modal to edit the proposal.
To trigger this behavior, modify the API key of the `usePinataIPFS` hook to something invalid. If the content of the proposal can't be uploaded to IPFS, the description won't load and it will show an error message instead.
Added two new IPFS API endpoints to retrieve files:
`https://davi.mypinata.cloud/`
`https://ipfs.fleek.co/`
Some minor changes:
1. Deleted IPFS util function since it was unused. Also removed `axios` library since that was the only place it was used.
2. Moved status circles (like the ones showed in the Tenderly simulation) to their own folder in `primitives`
3. Added translations
Closes #251
https://www.loom.com/share/b1595fa6fcb34cb1a069c1a86d563473
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#287 - feat: allow for signal proposals
DXgovernance:develop ← dcrescimbeni:feat/allow-signal-proposals
opened 07:28PM - 06 Sep 22 UTC
# Description
Allows the creation of signal proposals: proposals with options… and no actions.
You can vote on them, but trying to execute them causes a `Failed` state.
Closes #264
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#290 - Missing icons and buttons
DXgovernance:develop ← Kenny-Gin1:missing-icons-and-buttons
opened 04:12PM - 07 Sep 22 UTC
# Description
Added member icon to the upper left.
NOTE: The information b… utton was deliberately left out of this PR as per the comments in the issue.
Closes # [(issue)](https://github.com/DXgovernance/DAVI/issues/93)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
React testing library snapshot.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#291 - Better UX around proposals, adding expire time and a few seconds left
DXgovernance:develop ← rulfo71:refactor/ether-swr-guilds
opened 12:02PM - 08 Sep 22 UTC
# Description
- Issue #229
- Fix of "a second" left on proposal when it was u… nder a minute left. I had to do it manually because i couldn't find the error... i tried the exact same lines in a playground and moment.js (with the same version number) returns "a few seconds" but on DAVI returns "a second".
Closes #229
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#292 - Display voted option
DXgovernance:develop ← MiltonTulli:feat/display-chosen-vote
opened 02:39PM - 08 Sep 22 UTC
# Description
Once user has voted we hide voting options and show current votin… g info (option, voting power)
Closes https://github.com/DXgovernance/DAVI/issues/226
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
## Video
https://user-images.githubusercontent.com/25844967/189226245-f024908c-530a-41b6-b649-0146cf1e604f.mov
#293 - Initial branding
DXgovernance:develop ← rossneilson:demo
opened 04:52PM - 09 Sep 22 UTC
# Description
Initial logos from the demo branch
Also a null check
Closes… # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#296 - Adding watch to hooks that need it
DXgovernance:develop ← rossneilson:fix/watch-hooks
opened 11:13AM - 12 Sep 22 UTC
# Description
We added wagmi but didnt add watch params so just adding those … in where we need them so we always have up to date information.
We tested this previously in erc20 balances and had this behaviour previously so all should be good.
Also fixed a bit of logic around displaying mint rep in contract list.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#299 - Release/v0.0.0
DXgovernance:master ← DXgovernance:release/v0.0.0
opened 01:24PM - 12 Sep 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#302 - Multisig Guild members number not increasing
DXgovernance:develop ← rulfo71:develop
opened 08:04PM - 12 Sep 22 UTC
# Description
Added logic to UseGuildMemberTotal so that in case isRepGuild i… s true calls to the correct contract.
Closes #268
## Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [X] My code follows the existing style of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] Any UI changes have been tested and made responsive for mobile views
#307 - Footer
DXgovernance:develop ← MiltonTulli:feature/footer
opened 07:21PM - 13 Sep 22 UTC
# Description
Adding Davi Footer
Closes https://github.com/DXgovernance/DAVI… /issues/303
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#308 - Update content hash ens subdomains, add validations and refactor ENS content editor form
DXgovernance:develop ← dcrescimbeni:feat/update-content-hash-ens-subdomains
opened 11:38PM - 13 Sep 22 UTC
# Description
- This enables editing the content of the subdomain. Mostly add… ed validations. The core functionality is left untouched.
- The ENS content editor now uses `react-hook-form` that shows validation errors below the fields and prevents the user from submitting invalid data.
- Added fix for ENS action showing as "Unknown"
To test it:
1. Make sure you're on Goerli network
2. Make sure the `0xC5B20AdE9c9Cd5e0CC087C62b26B815A4bc1881` account is selected, or an account that is a member of the guild
3. Go to the Swapr guild
4. Make a new proposal with an action to change the ENS content. For now, the only ENS name is "swpr.eth" and the subdomain "test.swpr.eth"
5. Set the domain or subdomain (excluding the "eth" at the end)
6. Set the IPFS hash
7. Save and create the proposal
8. Vote and execute it
9. Go to https://app.ens.domains/name/swpr.eth/details
10. There should be an IPFS address (like ipfs://bafybeidovn3pkjyhtjiu5c2djp4v5ttsbh56jasiei3by5dgt7lduch6m4 )
11. Clicking on it should display the content set
12. To check the subdomain, click on "Subdomains", at the right of "Details"
Closes #177
For future issue: support IPFS CID v1
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#309 - docs: Added davi readme
DXgovernance:develop ← rossneilson:feature/readme
opened 01:40PM - 14 Sep 22 UTC
# Description
We still had dxvote readme in here, just updating things a bit.…
Let me know if there is anything I missed :)
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#312 - Display winning option
DXgovernance:develop ← MiltonTulli:feature/wining-option
opened 07:24PM - 14 Sep 22 UTC
# Description
- Display wining option if any. By default show option index 0. P… reviously we were ordering options at card wrapper level. Since choosing wining option seems to be concern from `ProposalCardWinningOption` I refactored it so it handles that logic.
- While I was testing I found 2 issues/warnings:
1. useERC20Info hook braking the app because of this line ` totalSupply: BigNumber.from(data[3]),` where data[3] was null.
2. missing translation key (wrong path to key)
Closes https://github.com/DXgovernance/DAVI/issues/277
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#315 - Added ProposalCardActionIcons
DXgovernance:develop ← Kenny-Gin1:feature/proposal-card-action-icons
opened 01:08PM - 16 Sep 22 UTC
# Description
- Adds a pen icon if you've written the proposal
- Adds a chec… k mark if you've voted on the proposal
- Added tests
<img width="890" alt="Screenshot 2022-09-20 at 16 06 58" src="https://user-images.githubusercontent.com/59825171/191283456-1f45685f-3878-43b5-a4fa-ebddd1cfff9a.png">
Closes # [(issue)](https://github.com/DXgovernance/DAVI/issues/255)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing and snapshot tests.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#317 - Hotfix: Fixing total locked in snapshot guild
DXgovernance:develop ← rossneilson:fix/tokens-locked-snapshot
opened 10:48AM - 19 Sep 22 UTC
# Description
We were getting current snapshot id in a lot of places and usin… g that to get total locked and voting power of. However if we are not looking at a proposal directly we do not want to do this as a new current snapshot id is only ever created once a proposal is made. So we cannot rely on this to get the most up to date token locked state. This resulted in users not being able to lock tokens or join the guild, now fixes.
Closes #316
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#319 - Release/v1.0.1
DXgovernance:master ← DXgovernance:release/v1.0.1
opened 12:56PM - 19 Sep 22 UTC
# Description
- ether-swr has been replaced with wagmi!
- Updated ENS conten… t support
- Orbis is implemented with discussions in governance page
- IPFS pinata pinning
- Signal proposals
- Show voted option
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#325 - Add approve to asset transfer permissions
DXgovernance:develop ← MiltonTulli:feature/approve-asset-transfer
opened 05:42PM - 19 Sep 22 UTC
# Description
Please include a summary of the change and which issue is fixed. … Please also include relevant motivation and context.
Closes https://github.com/DXgovernance/DAVI/issues/203
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
## Video
https://user-images.githubusercontent.com/25844967/191079977-01795161-8753-479a-ac71-d21f2e487590.mov
#326 - fix: Crash due to ethers receiving null value
DXgovernance:develop ← mprasanjith:bugfix/crash-in-isproposalcreationallowed-hook
opened 06:09PM - 19 Sep 22 UTC
# Description
Fixes the app crashing with a white screen due to Ethers gettin… g a null value.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#327 - Remove debugger from useEnsResolver hook
DXgovernance:develop ← MiltonTulli:fix/remove-debugger
opened 06:52PM - 19 Sep 22 UTC
#329 - GitHub workflow staging
DXgovernance:develop ← Kenny-Gin1:github-workflow-staging
opened 09:01AM - 20 Sep 22 UTC
# Description
Added github workflows to our `release/v.X.Y.Z` branches
Clo… ses # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#341 - Feat/raw transactions builder
DXgovernance:develop ← dcrescimbeni:feat/raw-transactions-builder
opened 06:59PM - 21 Sep 22 UTC
# Description
This adds the ability to create raw transactions. Also modifies… the display of "Unknown actions", adding the `to` address and the `value` (if present)
To create a new raw transaction:
1. Go to the "Create a new proposal" page.
2. Click on the "Add action" button
3. At the bottom of the modal, there's the option to show "Advanced options". Click to show "Raw transaction" action
4. Fill the data with a valid address, value and hex data (only one of them is required, but both could be present)
5. Save action and create the proposal
Screenshots:
Closes #304
There's currently an issue regarding testing the Number Input component: it works OK in the UI, but we can't replicate its behaviour in tests. If we fill valid data and try to submit the form, it shows like its invalid. For now I left a `// TODO` comment on those tests.
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing and added unit tests.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#349 - Support default values from rich contract data
DXgovernance:develop ← rulfo71:default-values-from-rich-contract-data
opened 10:47PM - 26 Sep 22 UTC
# Description
Support default values from rich contract data. Disable input b… y default when receiving data. Adding unlock icon to enable.
[22-09-26 Support default values from rich contract data.webm](https://user-images.githubusercontent.com/5303411/192393855-2f55daba-2381-41ef-a54f-baec4d242375.webm)
Closes #297
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested manually and added Tests
# Checklist:
- [X] My code follows the existing style of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] Any UI changes have been tested and made responsive for mobile views
#350 - Reconnect to the last chain and wallet correctly
DXgovernance:develop ← mprasanjith:bugfix/wallet-connection-bugfixes
opened 11:55AM - 27 Sep 22 UTC
# Description
Fixes issues with app not properly reconnecting to the previous… ly connected wallet and chain when opening a page in a new tab.
Closes #336.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested locally.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#351 - VotingPowerForProposalExecution
DXgovernance:develop ← MiltonTulli:fix/quorum-snapshot
opened 06:07PM - 27 Sep 22 UTC
# Description
- Create new `useVotingPowerForProposalExecution` hook to return … data according to guild type.
- Remove getVotingPowerForProposalExecution wagmi call from inside `useGuildConfig` hook and include data from new `useVotingPowerForProposalExecution` hook.
- Make swpr guild `SnapshotERC20Guild`
Closes https://github.com/DXgovernance/DAVI/issues/330
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#353 - Fix/remove default value in number input
DXgovernance:develop ← dcrescimbeni:fix/remove-default-value-in-number-input
opened 07:43PM - 28 Sep 22 UTC
# Description
Previously, since we couldn't pass a null value to BigNumber, t… he default values were set to '0'. This caused that we couldn't set empty input fields that contained values.
Now we can pass an empty string to the value and add `preventEmptyString` to force that value to `BigNumber.from(0)` if it's a string.
I also copy the comment in the `preventEmptyString` function:
Since strictNullChecks is set to false in tsconfig, if a value is null, it'll still be considered valid.
Passing a null value to BigNumber throws an error. To circumvent that limitation, a value could either be BigNumber or a string. This function prevents passing a string to a BigNumber method, and is used as a safeguard in cases where a value could be an empty string (not in cases that we actually want to pass a string to convert to BigNumber).
How to test it:
1. Go to the proposal creation page
2. Add actions that have amounts (transaction, vesting contract, swapr fees)
3. The inputs should appear empty, with only the placeholder showing
4. The number input fields should work as always (with the same validations)
Exceptions:
1. Lock tokens: since this input formats the value into BigNumber every 350ms, it'll still show a "0.0" after that time
2. Set Permissions > Function call: since switching tabs require to format the data to BigNumber, it'll still show "0.0"
Closes #332
Screenshot: when creating a new transfer action, the "Amount" field is empty, instead of showing "0"
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
All tests currently passing. Also added unit tests to check for edge cases.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#354 - Add vote buttons color && validate option label
DXgovernance:develop ← MiltonTulli:feature/voting-color-buttons
opened 09:02PM - 28 Sep 22 UTC
# Description
- Use colors for voting option buttons
- Validate option label t… o prevent adding "against" option and duplicated values
Closes https://github.com/DXgovernance/DAVI/issues/331
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
<img width="1060" alt="Screen Shot 2022-09-28 at 18 01 42" src="https://user-images.githubusercontent.com/25844967/192888054-ad830f42-1147-4a80-8dcf-ef0f73addc97.png">
#355 - Release/v1.1.0
DXgovernance:master ← DXgovernance:release/v1.1.0
opened 12:24PM - 29 Sep 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#357 - Proposal status pill is colored depending on status
DXgovernance:develop ← dcrescimbeni:feat/different-colors-for-proposal-state
opened 04:41PM - 29 Sep 22 UTC
# Description
The proposal status pill has different colors depending on the … status.
A change I made from the discussion is that "Executed" proposals are grey instead of a shade of green. I think this de-emphasizes them as they're already past proposals.
Currently I think there's no way to trigger a "Finished" state, but it is still configured to show a grey pill (the same as "Executed")
Closes #334
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manual testing.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#358 - Max opions && vote colors
https://github.com/DXgovernance/DAVI/pull/358
#364 - Hotfix: fixed vertical scrollbar in all proposals page
https://github.com/DXgovernance/DAVI/pull/364
#365 - Hotfix/vertical scrollbar in all proposals view
https://github.com/DXgovernance/DAVI/pull/365
#369 - Feat/allow ens addresses for address input
https://github.com/DXgovernance/DAVI/pull/369
#370 - Adding new contract to vote on dxdao in rich contracts
https://github.com/DXgovernance/DAVI/pull/370
#371 - Feature/use fathom
https://github.com/DXgovernance/DAVI/pull/371
#372 - Feature/dxdao vote rich data
https://github.com/DXgovernance/DAVI/pull/372
#373 - Release/v1.2.0
https://github.com/DXgovernance/DAVI/pull/373
#374 - Hide discussions
https://github.com/DXgovernance/DAVI/pull/374
#395 - Release/v2.0.0
https://github.com/DXgovernance/DAVI/pull/395
#396 - Add conditional flag to unsuported chain
https://github.com/DXgovernance/DAVI/pull/396
#402 - Updating bytecodes
https://github.com/DXgovernance/DAVI/pull/402
Experience Level: 4
Time commitment: 75%
Salary - Calculated from 75% rate:
Month 1
$4500 $ DAI
$3000 $ DXD d : Vested for 3 years with a 1 year cliff starting the [23/6/2022]
Month 2
$4500 DAI
$3000 DXD : Vested for 3 years with a 1 year cliff starting the [23/6/2022]
REP: 0.25005% - for 2 months
Salary for 2 months of work at Level 4, to be sent half on the first payment proposal and half on the second payment.
https://daotalk.org/t/filip-vidakovic-philipp16-worker-proposal-24-8-2022-24-10-2022/4509