Period review
The good:
As a QA Engineer, I have been responsible for ensuring the quality and reliability of our software product through testing and checking more from user perspective. During the past (period of time), I have focused on the following activities:
Collaborating with the team through PR’s and working on preparation DAVI for using on PROD env
Successful constant testing with retesting of PRs, i.e. Acceptance testing and Regression testing of platform
Developing and executing test cases to validate the functionality of the software
Using manual testing and automated testing tools to identify defects
In collaboration with Milan we changed configuration of synpress on DAVI project
Working with the team to verify that defects were properly fixed and that the software was functioning as intended
Retesting the software after defects were fixed to ensure that it was functioning as intended
Testing of Releases after branch out
During this period, I was able to identify a significant number of defects, which helped to improve the overall functionality and reliability of the software. I also made improvements to our testing processes, which helped to streamline our work and increase efficiency.
Overall, it has been a productive and successful period for the QA work. We have made significant progress in ensuring the quality of DAVI and we will continue to work closely with the devs to identify and fix any remaining defects. Also, preparing automation tests for CI/CD, working on Dockerization and setting up a Smoke test that will be triggered on every single commit.
Improvements:
Work more on automation tests now when we go to PROD env and there will probably be little less PR’s for manual testing. Work more on understanding of smart contracts and how some stuff works UTH. Be more consistent about planning with automation, because that is really something that we need for the near future, until now a much bigger priority was manual testing of PR’s and preparation of everything for PROD env. That means Regression testing on a daily basis, retesting after developers resolving PR’s and making other improvements. Also, want to work on self time management and improve overall relations with the team.
Proof of work:
#344 - Feat/permission check actions
DXgovernance:develop
← Kenny-Gin1:feat/permission-check-actions
opened 02:30PM - 22 Sep 22 UTC
# Description
This issue highlights whenever there's an action trying to be exe… cuted but for which the user does not have permission.
See video:
https://user-images.githubusercontent.com/59825171/201974426-423dd4a9-f2c7-4008-95c5-a2d4efad9dab.mp4
Closes # [(issue)](https://github.com/DXgovernance/DAVI/issues/306)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Unit testing and hook testing.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#403 - Feature/update bytecodes 2.0
DXgovernance:release/v2.0.0
← rossneilson:feature/update-bytecodes-2.0
opened 09:51PM - 10 Oct 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#404 - Fix/implementation rep issues
DXgovernance:develop
← rossneilson:fix/implementation-rep-issues
opened 06:02PM - 14 Oct 22 UTC
# Description
Added a loaded indicator which is used as a check before reques… ting more data from proposals.
Also saving bytecode to local storage for faster loading (pulling bytecode from chain can be slow)
Fixes a breaking bug in production and should be deployed as a hotfix
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#407 - feat: Support cid v1 in ens update action
DXgovernance:develop
← rossneilson:feat/cidv1
opened 07:29PM - 31 Oct 22 UTC
# Description
Supporting v1
Closes # (issue)
## Type of change
- [ ] … Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Adding support for v1 - new forked dependency
Removed validation due to unsupported dependency
Mocked new library due to failing tests
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#409 - Release/v2.0.1
DXgovernance:master
← DXgovernance:release/v2.0.1
opened 07:37PM - 31 Oct 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#411 - Fix block explorer links
DXgovernance:develop
← rulfo71:#338-fix-block-explorer-links
opened 02:41PM - 07 Nov 22 UTC
# Description
Fixing block explorer links through the app
Closes #338
…


## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manually for now
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#413 - fix: Updating bytecode for snapshot erc20 guild
DXgovernance:develop
← rossneilson:fix/update-erc20-bytecode
opened 10:07AM - 08 Nov 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#414 - fix: Fixing voting power on vote transaction for snapshot guilds
DXgovernance:develop
← rossneilson:fix/fix-voting-power-in-snapshot
opened 05:52PM - 08 Nov 22 UTC
# Description
Fixes
- Issue of sending non snapshot voting power to contrac… t despite UI showing correct amount (test by creating proposal->lock tokens->vote in proposal)
- Fixes position of quorum flag
- Adds ENS subdomain usage for contracts and tokens
- Uses new token list
- Makes token list scrollable
Closes #412
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#415 - Offline screen
DXgovernance:develop
← MiltonTulli:feature/offline-screen
opened 04:26PM - 09 Nov 22 UTC
# Description
Right now if Davi goes offline we get a white screen for multiple… errors. Adding a wrapper around Router to display a "no internet connection" card.
Closes https://github.com/DXgovernance/DAVI/issues/416
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views

#422 - Fix: component breaks after decimal value
DXgovernance:develop
← dcrescimbeni:fix/component-breaks-after-decimal-value
opened 09:49PM - 11 Nov 22 UTC
# Description
Added a new component: `<IntegerInput>` that takes the implemen… tation of `<NumericalInput>` but prevents the user from inputting dots.
An alternative would've been to add a prop to `NumericalInput`, but `FormElementRenderer` doesn't accept components with props.
Closes #410
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
1. Go to the proposal creation page
2. Add a new action: "Swapr fee"
3. The component to input the fee is an `IntegerInput`
4. It shouldn't let a user input anything but numbers
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#423 - use local richContract on development
DXgovernance:develop
← rulfo71:use-local-richContracts-on-development
opened 02:26PM - 15 Nov 22 UTC
# Description
On development use richcontracts from src/configs/ and on produ… ction uses "contracts.projectdavi.eth"
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
creating a proposal i checked that external contracts where the ones on src/configs
# Checklist:
- [X] My code follows the existing style of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#424 - Refactor: watch flags
DXgovernance:develop
← dcrescimbeni:refactor/watch-flags
opened 02:52PM - 16 Nov 22 UTC
# Description
## Replaced wagmi flags
Replaced `watch` flags with event li… steners. It no longer crashes if the mining interval is set low (like 500ms).
Before, the `useContractRead` hooks fired whenever a new block was mined. This was due to the `watch` flag set to true.
Now it listens to events related to the information the hook needs, and if that event is emitted, it fires a `refetch()`. Also, some hooks trigger a `refetch()` only when the event is related to that hook.
Examples:
- the `useProposal` hook triggers a refetch when `ProposalStateChanged` or `VoteAdded` events are emitted, only for that specific proposal ID.
- the `useGuildProposalIds` fires only when a `ProposalStateChanged` event is emitted, and that event has a `newProposalState` of 1 (new proposal).
Performance comparison with 500ms mining interval and 20 active proposals
*Before*

*Now*

## Upgraded wagmi to 0.7.15
Now the contracts are typed. It checks for the available methods we can execute on each contract. Also it type-checks the `data` returned from each contract.
This led to type checks in every place that used data returned by the contract.
The current 0.8 version of wagmi has a bug where the network detects the current network, but the provider is set to mainnet, so we had to downgrade to 0.7.15 that has all the useful features we needed.
## Other notes
Currently I had to temporarily disable storybook, as there was an error in wagmi while building it.
Also, since the hooks now listen for events, the network tab (developer console > network) gets crowded with calls. Opening it will consume plenty of resources since it records the network activity.
Closes #362
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manually tested.
This PR doesn't change any existing behavior, so the focus of the tests is to check that everything works as always.
**Testing interactions:**
A good test setup would be having two windows opened. Doing an action in one (voting, creating a proposal, locking tokens, executing a proposal, etc) should impact the other window without a need to refresh.
**Testing fast mining:**
In the `hardhat.config.js` file, in the localhost mining interval network configuration (as of now, line 121), set it to a low number (like 500) to increase the mining speed. This will cause some slowdown on the PC (since it's mining faster), but shouldn't crash the UI. Interactions with the app should work ok.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#425 - version 2.1.0
DXgovernance:develop
← rulfo71:develop
opened 01:34PM - 21 Nov 22 UTC
# Description
upgrading version to 2.1.0
Closes # (issue)
## Type of c… hange
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#429 - Locktime & proposalTime error label fix
DXgovernance:develop
← MiltonTulli:fix/setGuildConfig-validation-error
opened 05:35PM - 21 Nov 22 UTC
# Description
- Add conditional flag to display (or not) X icon on `NumericalIn… put` component to avoid founded issue.
<img width="609" alt="Screen Shot 2022-11-21 at 14 00 41" src="https://user-images.githubusercontent.com/25844967/203122321-b8d478fd-ad70-45e5-a775-2af8a3f618cb.png">
- Display proper error label on `lockTime` and `proposalTime` fields for setGuildConfig Actions. Only display error for updated field, not both.
<img width="392" alt="Screen Shot 2022-11-21 at 14 19 38" src="https://user-images.githubusercontent.com/25844967/203122419-e340122a-1fb2-451e-ba6e-e7c2e3617265.png">
Closes https://github.com/DXgovernance/DAVI/issues/427
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#432 - fix: Overrides default rpc to port for mainnet
DXgovernance:develop
← rossneilson:fix/default-chain-rpc
opened 03:25PM - 23 Nov 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes #431
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#433 - Fix: TokenAmountInput auto-formatting issue
DXgovernance:develop
← dcrescimbeni:fix/token-amount-delay-fix
opened 04:03PM - 23 Nov 22 UTC
# Description
Fixed auto-formatting issue in the `TokenAmountInput` component… .
Before: after a delay of 350ms the field will auto-format, adding a dot and a decimal.
Now: it doesn't format it automatically. If the value is invalid (like ending with a dot) it will change the value to `null` and prevent the form from submitting.
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
1. Go to the new proposal page, and select a new "Transfer" action
2. The "Amount" input shouldn't auto-format, nor let you submit if the number ends with a dot.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#434 - Release/v2.1.1
DXgovernance:master
← DXgovernance:release/v2.1.1
opened 04:33PM - 23 Nov 22 UTC
# Description
Please include a summary of the change and which issue is fixed… . Please also include relevant motivation and context.
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#451 - Release/v2.2.0
DXgovernance:master
← DXgovernance:release/v2.2.0
opened 10:37AM - 06 Dec 22 UTC
# Changelog
- :rocket: Added `approve` call to asset transfer permissions
- … :wrench: Replaced `watch` flags for event listeners
- :wrench: Upgraded `wagmi` library to 0.7.15
- :bug: Fixed "X" incorrectly showing on some `NumericalInput` components
- :bug: Fixed error display on `setGuildConfig`
#455 - Fix: white spaces on address input
DXgovernance:develop
← rulfo71:fix-white-spaces-on-address-input
opened 02:07PM - 07 Dec 22 UTC
# Removing white spaces on address input
Also added a validation of null on u… seTimeDetail.ts
Closes #448
## Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
- Create a proposal
- Add action
- Transfer
- On Recipient try to add white spaces and it shouldn't allow you
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#457 - feat: Adding token picker input, new rich contract and tidying up css
DXgovernance:develop
← rossneilson:feature/adding-token-picker-input
opened 03:00PM - 08 Dec 22 UTC
# Description
- Adding token picker input as rich contarct data form option
… - Adding new rich contract data for bridging
- Fixed CSS around generic action line
- Now referencing local rich contract json for local development


Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#459 - Fix: proposal text not contained
DXgovernance:develop
← dcrescimbeni:fix/proposal-text-not-contained
opened 02:17PM - 09 Dec 22 UTC
# Description
Long words with no spacing (like long links) in the proposal de… scription were not contained and overlapped with other elements. Also, spacing between words was uneven.
Now it breaks words in multiple lines, and aligns text to the left instead of justified.
## Screenshots
Proposal referenced in the issue:

Long proposal description with long link (ft. ChatGPT):

Closes #438
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Snapshot test.
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#460 - Allow setting of value in function call permissions setting
DXgovernance:develop
← rulfo71:allow-setting-value-in-function-call-permissions-setting
opened 03:39PM - 09 Dec 22 UTC
# Description
Allow setting of value in function call permissions setting
… [Screencast from 09-12-22 12:01:47.webm](https://user-images.githubusercontent.com/5303411/206737804-c3f29888-3576-46a5-aebe-d958bcd20a89.webm)
Closes #442
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Create proposal, add action, set permissions, function call, change amount
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#461 - Comment orbis
DXgovernance:develop
← ParallaxNetwork:comment-orbis
opened 07:21AM - 13 Dec 22 UTC
# Description
Add a new reusable discussion component based on [Orbis Decentr… alized Social Protocol](https://orbis.club/) using [Orbis SDK](https://www.npmjs.com/package/@orbisclub/orbis-sdk)
[Project-Davi-Discussion.webm](https://user-images.githubusercontent.com/112882827/207319810-17ef4488-b5f3-4476-a618-bf72e942c88b.webm)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Tested live at https://davi-discussion.vercel.app on proposal page
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] Any UI changes have been tested and made responsive for mobile views
#463 - Various fix on actions (Vestings and raws)
DXgovernance:develop
← rulfo71:fix-action-options
opened 12:52PM - 15 Dec 22 UTC
Closes:
- DXgovernance/davi-monorepo#5
- DXgovernance/davi-monorepo#4
- DXg… overnance/davi-monorepo#3
# Description
- Removing call from editable action and checking null.
- Iterating on decodedActions instead of Actions for options
- Fix on getPermissionArgs for raw transactions
both bugs found with madusha and ross
Before:
[Screencast from 15-12-22 12:05:41.webm](https://user-images.githubusercontent.com/5303411/207896117-50db9eac-0937-496b-96f8-911d4bb14b21.webm)
After:
[Screencast from 15-12-22 12:06:54.webm](https://user-images.githubusercontent.com/5303411/207896140-c68a72be-3e34-491d-953b-3953d5bbe796.webm)
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
adding action vesting contracts
# Checklist:
- [x] My code follows the existing style of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
#468 - feat: Adding discussion to proposal flow and pages
DXgovernance:develop
← rossneilson:comment-orbis
opened 01:09PM - 20 Dec 22 UTC
# Description
The new flow for governance is: Create discussion -> Create pro… posal
Discussions can have multiple proposals created from them
Our proposals now reference an orbis/ceramic stream ID so we can easily link discussions and proposals and do more complex queries
RIght now its very simple and we will later add reactions, links and more
Closes # (issue)
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
# Checklist:
- [ ] My code follows the existing style of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any UI changes have been tested and made responsive for mobile views
Compensation:
Experience Level: 4
Time commitment: 75%
Salary - Calculated from 75% rate:
Month 1
$4500 $ DAI
$3000 $ DXD d : Vested for 3 years with a 1 year cliff starting the [23/6/2022]
Month 2
$4500 DAI
$3000 DXD : Vested for 3 years with a 1 year cliff starting the [23/6/2022]
REP: 0.25005% - for 2 months
Salary for 2 months of work at Level 4, to be sent half on the first payment proposal and half on the second payment.
Previous work:
Timeframe:
24/10/2022 - 24/12/2022
2 months
Responsibilities:
Guilds PRs Manual Testing
UI Testing
Smoke Testing
Acceptance Testing
Regression Testing
Integration Testing
Clear and detailed bugs reporting
Writing and improving test cases
Writing and improving test scenarios
Writing Automation test plans
Establishing Automation framework with collaboration with @millan
Writing and executing Automated Tests
UI Testing
Smoke Testing
Acceptance Testing
Regression Testing
Continue to learn m…