I am planning to this proposal in xDxdao to get confirmation that I will be compensated upon the completion of the following tasks:
Dxvote v.1.0 Minimal voting dapp to create proposals, vote and stake on Arbitrum/xDai. (Priority to deploy to arbitrum).
DXvote v1.0 milestone issues
opened 02:15PM - 02 Feb 21 UTC
This is a very important feature!
There is information and data that we know … that wont change, this are proposals that were executed and votes and staking that were already done. We dont need to query that information from the blockchain every time if we have a source of truth that we can trust. This will incrase a lot the dapp performance by querying only the necessary data.
We already have a tool that generates an snapshot of all the dxdao information and it creates a "dxdao database", we can identify the immutable data from this DB and use it in the dapp.
The first approach would be to place a .json file that will be updated regularly, lets say once a month on each new dxvote release.
This .json file will act as our immutable DB allowing us to query and navigate trough old proposals very fast :)
opened 02:17PM - 02 Feb 21 UTC
If there is an etherscan API key added in the dapp, the proposal call will be de… coded in the proposal information page showing the functions to be called using `functionName(arguments) with X ETH`
opened 02:19PM - 02 Feb 21 UTC
Improve overall documentation of the dapp, describe how the developer operations… works and dapp development process, to make it easier for developers to contribute.
opened 02:24PM - 02 Feb 21 UTC
In the create proposal pages show a recommended set of functions as first option… s in the proposal calls edition.
opened 02:25PM - 02 Feb 21 UTC
Right now the dapp is showing all proposals, we want to be able to filter them b… y scheme, state and title.
opened 03:24PM - 23 Mar 21 UTC
The user should be able to see the actions done by any user when seeing the user… s page. It should show all the proposals creations, stakes, votes, redeems and executions. Ordered by date.
opened 03:47PM - 23 Mar 21 UTC
Whenever a proposal is submitted, a vote sent or a stake is done the user should… see that he has a transaction pending with an action and should be notified in the dapp when the action is executed successfully or not.
opened 03:51PM - 23 Mar 21 UTC
Right now the proposal description is submitted to ipfs when the proposal is cre… ated and sometimes it fails, this should be improved by allowing the user upload the proposal description doc to IPFS before submitting the proposal on chain, this way the user will be 100% sure that his proposal description is online when submitting the proposal.
So the user should be able to "upload to IPFS" and see a link to the uploaded document, where he can verify the content of the proposal that will be shown online.
opened 03:52PM - 23 Mar 21 UTC
The user should be able to add his pinata API key, allowing him to pin his conte… nt and even important DXdao files to his pinata account.
opened 01:32PM - 24 Mar 21 UTC
**Describe the task that needs to be done**
We need to have the smart contracts… for Gov 1.x deployed in rinkeby and xdai or arbitrum.
**Describe how you have considered doing it**
When we believe the code is ready to be audited a deployment can be done in rinkeby and we can use those contracts while they go trough an audit and we can do another redeployment with the changes applied after audit.
**Describe how do you expect to test the task resolution**
This would be resolved when the audited smart contracts are deployed in rinkeby and another network like xdai or arbitrum.
opened 01:57PM - 08 Apr 21 UTC
**Describe the bug**
After some time, lets say.. 48hs? The body of the proposal… is not being loaded form IPFS, I guess it needs to be pinned somewhere in order to be kept alive in the ipfs network.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to https://augustol.github.io/dxvote/#/scheme/0x01DD430f1C4f4aA1300309Bcc0C5C66Ab59259bA/proposal/0x95a51d34c3541b0fbf3d94036766f2b47c40919896a178b65c1998a9718a49cb
2. After opening the console I see the description hash of the proposal is e30101701220def6340da821ad09f60720c29fa60a22d3e5f4133756af6194f356602fa70d44
3. If I decode the content hash in https://content-hash.surge.sh/ I get an IPFS record https://gateway.ipfs.io/ipfs/QmdLzxk9C4V4vYFupCFrQBTFUhxFfvUjiRx8tyVq6yyy5V/
4. The content is not there.
**Expected behavior**
I expect the proposal to load the description of the proposal from IPFS.
**Desktop (please complete the following information):**
- OS: Ubuntu 20.04
- Browser Brave
- Version 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
opened 02:03PM - 08 Apr 21 UTC
bug
**Describe the bug**
The config and user links in the navbar redirects to the w… orng path when I click on them
redirects to https://augustol.github.io/#/config and should be https://augustol.github.io/dxvote/#/config
**To Reproduce**
Steps to reproduce the behavior:
1. Click on the user or config icon in the navbar
2. The page breaks
**Expected behavior**
Should redirect to https://augustol.github.io/dxvote/#/config or https://augustol.github.io/dxvote/#/user/ADDRESS
**Desktop (please complete the following information):**
- OS: Ubuntu 20.04
- Browser Brave
- Version 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
opened 07:15PM - 15 Apr 21 UTC
**Is your feature request related to a problem? Please describe.**
Feature requ… est! I think there is a missing signal in the UI on proposals. It's easy to see who submitted a proposal and who voted for and against a proposal, but there is no place in Alchemy or DXvote (i think) to show the address of the account that boosted it. That way, a voter can see, "Oh Augusto boosted it, he probably tested it". This is no guarantee of course and all voters should do their own diligence but any signal is good.
**Describe the solution you'd like**
When you hover over the amounts staked on "For" or "Against", it shows the address(es) that boosted it.
<img width="359" alt="Screen Shot 2021-04-15 at 3 09 29 PM" src="https://user-images.githubusercontent.com/47428627/114925206-cfe2d180-9dfc-11eb-82d5-87a7b098b502.png">
**Describe alternatives you've considered**
Or it could be displayed at the bottom of the proposal. Like "Boosted by 0x090"
**Additional context**
Definitely for 1.3/4/5 and not an immediate priority!
opened 07:29PM - 15 Apr 21 UTC
**Describe the bug**
I created this proposal: https://augustol.github.io/dxvote… /#/scheme/0x200188373f1346c615089b8a880E64de2C0854eC/proposal/0xceb4535dea19c8dc63562e005c376e43ed21baceeb4b98688517e3bebcdac3e7
but when I pressed submit and confirmed the tx on my metamask, i was still on the 'proposal submission' page, even after the tx had confirmed. I feel like it should take me back to the list of proposals after I've submitted the tx?
**To Reproduce**
Steps to reproduce the behavior:
1. Go to DXvote
2. Click on + 'New Proposal'
3. Create your proposal!
4. Press submit
5. And wait...
**Expected behavior**
After I pressed submit and confirmed the tx on metamask, I expected to be taken back to the home page and list of proposals. Or just closing the proposal page or maybe even some confirmation
**Screenshots**
Just stuck here:
<img width="1197" alt="Screen Shot 2021-04-15 at 3 20 12 PM" src="https://user-images.githubusercontent.com/47428627/114927240-41bc1a80-9dff-11eb-8e5e-1af7a9c0ce54.png">
**Desktop (please complete the following information):**
- OS: Mac M1
- Browser Firefox
- Version 87.0
**Additional context**
Add any other context about the problem here.
opened 07:57PM - 15 Apr 21 UTC
**Describe the bug**
I went to boost this proposal
https://augustol.github.io/… dxvote/#/scheme/0x200188373f1346c615089b8a880E64de2C0854eC/proposal/0xceb4535dea19c8dc63562e005c376e43ed21baceeb4b98688517e3bebcdac3e7
I was able to approve DXD for staking, but when I went to do the Staking transaction, my metamask prompt had an error in this. Here is the failed transaction:
https://rinkeby.etherscan.io/tx/0x3f32bf03285084732166d1f5c267ab336f965e2ee951f6e99ef084b0343b112e
This same thing happened when I tried to vote on the proposal too.
https://rinkeby.etherscan.io/tx/0x0412f02bd3d2f2704926bc58fddd56958f1c6c27080778a5d7635ea3db5c69f1
Screen shots below
**To Reproduce**
Steps to reproduce the behavior:
1. Go to any proposal that can be boosted
2. Approve DXD staking, confirm in metamask
3. Click 'Stake' button
4. See error in metamask prompt
**Expected behavior**
I wanted to stake on this proposal and vote on it because I think DXvote is the most decentralized voting interface
**Screenshots**
<img width="351" alt="Screen Shot 2021-04-15 at 3 46 32 PM" src="https://user-images.githubusercontent.com/47428627/114930624-3965de80-9e03-11eb-87cc-5d87eb21e479.png">
**Desktop (please complete the following information):**
- OS: Mac M1
- Browser Firefox
- Version 87.0
**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
**Additional context**
Add any other context about the problem here.
opened 08:09PM - 16 Apr 21 UTC
Deploy dxdao gov 1.x contracts in arbitrum network.
The deployment can be don… e running the deployment script in dxdao-contracts, it will likely need some code changes. Then the arbitrum network needs to be added in the dxvote dapp and use the deployed contracts.
This task will be resolved when proposals are created voted and staked over the arbitrum network.
opened 02:36PM - 21 Apr 21 UTC
**Problem**
The voting machine smart contract that we are using requires to cal… l the `_execute` function to pass a proposal form the preBoosted to the boosted state, this action should happen next time a proposal is voted once that past the boost time threshold or when is executed.
**Solution**
Make the necessary changes in the DXDVotingMachine smart contract to have the desired behaviour.
**Additional context**
DXDVotingMachine contract: https://github.com/AugustoL/dxdao-contracts/blob/dxdao-contracts/contracts/dxdao/DXDVotingMachine.sol
opened 02:46PM - 21 Apr 21 UTC
**Problem**
The genesis protocol machine that we are using allows any the execu… tion of any boosted proposal with any amount of positive votes, this means that if a boosted proposal reach the execution time with 1 REP it will be executed. We have been talking about this and we considered this a problem, we need to be able to set up a mimum amount of positive votes required for a proposal to be executed.
**Solution**
Modify the configuration parameter in the voting machine contract called `queuedVoteRequiredPercentage` to be an array of uints, having in the first index the `queuedVoteRequiredPercentage` and in the second index the `boostedVoteRequiredPercentage`.
Every time a boosted proposal will be executed the amount of % in prositive votes needs to be higher than `boostedVoteRequiredPercentage`
**Additional context**
DXDVotingMachine contract: https://github.com/AugustoL/dxdao-contracts/blob/dxdao-contracts/contracts/dxdao/DXDVotingMachine.sol
Dxdao Smart Contracts : The smart contracts for gov 1.x were sent to be audited and we will have the results next week. I also commit to apply the necessary changes after the audit and redeploy the contracts to rinkeby for dxdao users to use the dapp at any time.
Developer and Governance calls: I commit to attend both calls and in case I cannot let the coworkers know and communicate anything I consider important before the calls.
I already started working on this tasks during this month, and I reviewed and talked with dxdao members after governance calls about what they think is important to have for the first version.
I estimate this tasks will take me a month and a half of work, and I will try to deliver them by end of may.
To verify the completion of my tasks I will try to be paid using DXvote on xDai or Arbitrum once it is deployed on any of this networks with audited contracts.
Experience Level: 5
Estimated Time: 6 Weeks (1.5 months).
Working for DXdao since 04/2020.
12000 USD.
9000 USD in DXD vested for 2 year with 1 year cliff starting the 1/04/2021.
0.1667% REP at based on latest REP supply on mainnet at the moment of submitting the worker payment.
7 Likes
Hola, just wanted to give an update on this myself.
In my opinion I already did everything I committed myself and even more (that was the idea). But I still havent deployed to xdai to receive my payment and more work is popping up and I cant stop and decide and organize on what Im going to work on I am going to create another contribution proposal #2 to be payed the extra work I did this last weeks and what I will be working on the following months.
We did two audits , both of the documents are in the repository, publicly available, I tried to document it and do it as better as possible. In the proposal I commited to work on one audit, but then we decided that we could use another one and I have to say that the results of both of them were very positive and I am super confident in the security of the dxvote contracts after being so carefully reviewed. I took the time to take each issue very seriously and fix everything that was submitted.
Extra work I did on the dxdao-contarcts repo:
One audit report and changes.
Added continuous integration script to run linter, tests and coverage in each PR.
Reached 100 % test coverage in WalletScheme and PermissionRegistry smart contracts.
Now Im working on a PR (Augustol develop by AugustoL · Pull Request #16 · AugustoL/dxdao-contracts · GitHub ) that documents better how the DXvote contracts works, organize a bit more the contracts in folders and add contract tools like NFTMinter and VestingFactory.
The main reason I went ahead and worked more than I committed myself was because dxdao required it and I had time available. I estimate that it was 2 more weeks of work, I am going to ask for its compensation later in my next worker contribution proposal. It would be good to know if someone has any problem with it before going ahead, if you do please let me know here.
6 Likes